Commit Graph
2 Commits
Author SHA1 Message Date
Hermes 3db86754b3 feat: Define plugin interface specification and add core module tests
Addresses audit findings A001, T002:

A001 - Undefined Plugin Interface:
- Created src/plugins/interface.py with abstract PluginBase class
- Defined AnalysisPlugin, VisualizationPlugin extensions
- Documented required methods (register_menu) and metadata attributes
- Added version compatibility constants and capability validation

T002 - Test Coverage for Core Modules:
- tests/unit/test_plugin_manager.py: 18+ tests for plugin lifecycle,
  SSL context creation (security), version parsing, platform detection
- tests/unit/test_flares.py: 25+ tests for color mapping, QC metrics,
  data validation, parameter defaults, path handling

Total test coverage increase: +43 test functions across 3 modules.
2026-11-07 15:28:06 -07:00
Hermes 516397dd96 security: Fix command injection vulnerability in updater.py
- Add shlex.quote() on all path arguments before subprocess calls (lines 404-407)
- Consolidate duplicated version_compare() function into single module-level utility
- Remove three identical class methods from UpdateCheckThread, LocalPendingUpdateCheckThread, and UpdateManager
- Add comprehensive test suite for updater.py security-critical functionality
- Add requirements-dev.txt with pytest dependency

Addresses critical security findings from flares_audit_report.md:
  S001: Command Injection in Updater (CVSS ~7.5)
  Q001: Duplicated version_compare logic
  T001: Insufficient test coverage for updater.py
2026-11-07 15:14:32 -07:00